EECS2030 Lab 3 Feedback

2 / 2  -passes all unit and style tests?

--------------------
TA Comments:

--------------------
Style checker output:

--------------------
Unit tester output:

Passed all unit tests.

--------------------

Your submission:

Complex.java

package eecs2030.lab3;

import java.util.Arrays;
import java.util.List;

/**
 * A class that represents immutable complex numbers.
 * 
 * @author EECS2030 Fall 2017-18
 * 
 */
public final class Complex {

        private final double real;
        private final double imag;

        public static final Complex ONE = new Complex(1.0, 0.0);
        public static final Complex I = new Complex(0.0, 1.0);

        /**
         * Initializes this complex number to <code>0 + 0i</code>.
         * 
         */
        public Complex() {
                this(0.0, 0.0);
        }

        /**
         * Initializes this complex number so that it has the same real and
         * imaginary parts as another complex number.
         * 
         * @param other
         *            the complex number to copy.
         */
        public Complex(Complex other) {
                this(other.real, other.imag);
        }

        /**
         * Initializes this complex number so that it has the given real and
         * imaginary components.
         * 
         * @param re
         *            the real part of the complex number.
         * @param im
         *            the imaginary part of the complex number.
         */
        public Complex(double re, double im) {
                this.real = re;
                this.imag = im;
        }

        /**
         * A static factory method that returns a new complex number whose real part
         * is equal to re and whose imaginary part is equal to 0.0
         * 
         * @param re
         *            the desired real part of the complex number
         * @return a new complex number whose real part is equal to re and whose
         *         imaginary part is equal to 0.0
         */
        public static Complex real(double re) {
                return new Complex(re, 0.0);
        }

        /**
         * A static factory method that returns a new complex number whose real part
         * is equal to 0.0 and whose imaginary part is equal to im
         * 
         * @param im
         *            the desired imaginary part of the complex number
         * @return a new complex number whose real part is equal to 0.0 and whose
         *         imaginary part is equal to im
         */
        public static Complex imag(double im) {
                return new Complex(0.0, im);
        }

        /**
         * Get the real part of the complex number.
         * 
         * @return the real part of the complex number.
         */
        public double re() {
                return this.real;
        }

        /**
         * Get the imaginary part of the complex number.
         * 
         * @return the imaginary part of the complex number.
         */
        public double im() {
                return this.imag;
        }

        /**
         * Add this complex number and another complex number to obtain a new
         * complex number. Neither this complex number nor c is changed by this
         * method.
         * 
         * @param c
         *            The complex number to add to this complex number.
         * @return a new Complex number equal to the sum of this complex number and
         *         c.
         */
        public Complex add(Complex c) {
                return new Complex(this.real + c.real, this.imag + c.imag);
        }

        /**
         * Multiply this complex number with another complex number to obtain a new
         * complex number. Neither this complex number nor c is changed by this
         * method.
         * 
         * <p>
         * This is not an industrial strength implementation of complex number
         * multiplication. In particular, issues related to the differences between
         * <code>-0.0</code> and <code>0.0</code> and infinite real or imaginary
         * parts are not taken into account.
         * 
         * @param c
         *            The complex number to multiply by.
         * @return a new Complex number equal to this complex number multiplied by
         *         c.
         */
        public Complex multiply(Complex c) {
                double multReal = ((this.real * c.real) - (this.imag * c.imag));
                double multImag = ((this.imag * c.real) + (this.real * c.imag));
                return new Complex(multReal, multImag);
        }

        /**
         * Compute the magnitude of this complex number.
         * 
         * @return the magnitude of this complex number.
         */
        public double mag() {
                return Math.hypot(this.real, this.imag);
        }

        /**
         * Return a hash code for this complex number.
         * 
         * <p>
         * This implementation uses a very crude algorithm to compute the hash code;
         * the hash code is computed as follows:
         * 
         * <ol>
         * <li>compute the value equal to <code>9999</code> times the real part of
         * this complex number
         * <li>compute the value equal to <code>99</code> times the imaginary part
         * of this complex number
         * <li>compute the sum of the values computed in Steps 1 and 2
         * <li>casts the value computed in Step 3 to an <code>int</code>
         * <li>returns the value computed in Step 4
         * </ol>
         * 
         * <p>
         * In production code, consider implementing hashCode() using
         * {@link java.util.Objects#hash}
         * 
         * @return a hash code value for this complex number.
         */
        @Override
        public int hashCode() {
                return (int) ((9999 * this.real) + (99 * this.imag));
        }

        /**
         * Compares this complex number with the specified object. The result is
         * <code>true</code> if and only if the argument is a <code>Complex</code>
         * number with the same real and imaginary parts as this complex number.
         * 
         * @param obj
         *            the object to compare this Complex number against.
         * @return true if the given object is a Complex number equal to this
         *         complex number, false otherwise.
         */
        @Override
        public boolean equals(Object obj) {
                if (this == obj) {
                        return true;
                }
                if (obj == null) {
                        return false;
                }
                if (this.getClass() != obj.getClass()) {
                        return false;
                }
                Complex other = (Complex) obj;
                if (Double.doubleToLongBits(this.real) != Double.doubleToLongBits(other.real)) {
                        return false;
                }
                if (Double.doubleToLongBits(this.imag) != Double.doubleToLongBits(other.imag)) {
                        return false;
                }
                return true;

        }

        /**
         * Returns a string representation of this complex number.
         * 
         * <p>
         * The returned string is the real part of the complex number, followed by a
         * space, followed by a <code>+</code> or <code>-</code> sign, followed by a
         * space, followed by the absolute value of the imaginary part of the
         * complex number, followed by an <code>i</code>. The sign is <code>+</code>
         * if the imaginary part of the complex number is positive, and
         * <code>-</code> if the imaginary part of the complex number is negative.
         * 
         * For example the complex number with real and imaginary parts equal to
         * zero has the string representation <code>0.0 + 0.0i</code>. The complex
         * number with real part equal to zero and imaginary part equal to
         * <code>-1</code> has the string representation <code>0.0 - 1.0i</code>.
         * 
         * @return a string representation of this complex number.
         * 
         */
        @Override
        public String toString() {
                String sign = "+";
                if (this.imag < 0) {
                        sign = "-";
                }
                return Double.toString(this.real) + " " + sign + " " + Double.toString(Math.abs(this.imag)) + "i";
        }

        /**
         * Returns a complex number holding the value represented by the given
         * string.
         * 
         * <p>
         * <code>valueOf</code> tries to create a complex number from a string
         * representation of the complex number. Strings that can interpreted as
         * complex numbers are those strings returned by
         * <code>Complex.toString</code>.
         * 
         * @param s
         *            a string representation of a complex number.
         * @return a Complex number equal to the complex number represented by the
         *         given string.
         * @throws IllegalArgumentException
         *             if the string cannot be interpreted as a complex
         *             number. @pre. s has a space before and after the + or - sign
         *             separating the real and imaginary parts of the complex number
         */
        public static Complex valueOf(String s) {
                Complex result = null;
                String t = s.trim();
                List<String> parts = Arrays.asList(t.split("\\s+"));
                double re;
                double im;
                // split splits the string s by looking for spaces in s.
                // If s is a string that might be interpreted as a complex number
                // then parts will be a list having 3 elements. The first
                // element will be a real number, the second element will be
                // a plus or minus sign, and the third element will be a real
                // number followed immediately by an i.
                //
                // To complete the implementation of this method you need
                // to do the following:
                //
                // -check if parts has 3 elements
                if (parts.size() != 3) {
                        System.out.println("size");
                        throw new IllegalArgumentException();
                }
                // -check if the second element of parts is "+" or "-"
                if (!parts.get(1).equals("+") && !parts.get(1).equals("-")) {
                        System.out.println("plus minus");
                        System.out.println(parts);
                        throw new IllegalArgumentException();
                }
                // -check if the third element of parts ends with an "i"
                if (!parts.get(2).endsWith("i")) {
                        System.out.println("ends with i");
                        throw new IllegalArgumentException();
                }
                // -if any of the 3 checks are false then s isn't a complex number
                // and you should throw an exception
                // -if all of the 3 checks are true then s might a complex number
                // -try to convert the first element of parts to a double value
                // (use Double.valueOf); this might fail in which case s isn't
                // a complex number
                try {
                        re = Double.valueOf(parts.get(0));
                } catch (Exception e) {
                        System.out.println("value of 1");
                        throw new IllegalArgumentException();
                }
                // -remove the 'i' from the third element of parts and try
                String imSt = parts.get(2).substring(0, parts.get(2).length() - 1);
                // to convert the resulting string to a double value
                // (use Double.valueOf); this might fail in which case s isn't
                // a complex number
                try {
                        im = Double.valueOf(imSt);
                } catch (Exception e) {
                        System.out.println("value of 2");
                        throw new IllegalArgumentException();
                }
                // -you now have real and imaginary parts of the complex number
                // but you still have to account for the "+" or "-" which
                // is stored as the second element of parts
                // -once you account for the sign, you can return the correct
                // complex number
                if (parts.get(1).equals("+")) {
                        result = new Complex(re, im);
                }
                if (parts.get(1).equals("-")) {
                        im = im * -1.0;
                        result = new Complex(re, im);
                }
                return result;
        }

}

MandelbrotUtil.java

package eecs2030.lab3;

public class MandelbrotUtil {

        private MandelbrotUtil() {

        }

        /**
         * Return the number of iterations needed to determine if z(n + 1) = z(n) *
         * z(n) + c remains bounded where z(0) = 0 + 0i. z(n + 1) is bounded if its
         * magnitude is less than or equal to 2. Returns 1 if the magnitude of c is
         * greater than 2. Returns max if the magnitude of z(n + 1) is less than or
         * equal to 2 after max iterations.
         * 
         * <p>
         * If z(n + 1) remains bounded after max iterations then c is assumed to be
         * in the Mandelbrot set.
         * 
         * @param c
         *            a complex number
         * @param max
         *            the maximum number of iterations to attempt
         * @return the number of iterations needed to determine if z(n + 1) = z(n) *
         *         z(n) + c remains bounded where z(0) = 0.0 + 0.0i. @pre. max is
         *         greater than 0
         */
        public static int mandelbrotIterations(Complex c, int max) {
                Complex z = new Complex(0.0, 0.0);

                // You need a loop here. Inside the loop, set z to z * z + c
                // (i.e. perform one iteration of the equation) and
                // check if the magnitude of z is greater than 2; if
                // the magnitude is greater than 2 then return the
                // number of times you computed z * z + c.
                // If you compute z * z + c max times and the magnitude
                // of z is still less than or equal to 2 you should
                // return max.

                for (int i = 1; i < max; i++) {
                        z = (z.multiply(z)).add(c);
                        if (z.mag() > 2.0) {
                                return i;
                        }
                }
                return max;
        }
}